Re: Viewing code in Gerrit

[Hadriel Kaplan <hadriel.kaplan () oracle com>]

On Mar 24, 2014, at 11:26 AM, Bill Meier <wmeier () newsguy com> wrote:

> On 3/24/2014 9:21 AM, Evan Huus wrote:
> > In summary: the diff is computed locally in javascript, and seems to
> > be worse than O(n) on the size of the underlying file; viewing the
> > diff for any file >1k lines may be slow, but if you just let it run it
> > will finish eventually. Avoid epan/enterprise-numbers and other files
> > with 100k+ lines, they take many minutes to finish.
>
> IOW: The 2 versions being diff'd are downloaded in total before doing a local compare ?
>
> If so, UGH ....

Fwiw, I think it's more and more common to do that type of thing these days in web JS apps - distributes the load to 
the clients vs. centralizing the load on the server (and takes less state/memory on the server too).  For the bandwidth 
issue Google's been trying to push SPDY which uses deflate compression.

-hadriel

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe