Re: Export ssl_starttls_ack for plugins

["Juan Pablo Mendoza" <jpmendoza () awesomemail xyz>]

> On 31 May 2016 at 15:14, Juan Pablo Mendoza <jpmendoza () awesomemail xyz>
> wrote:
>
> > Hello,
> >
> > I'm writing a dissector plugin for a in-house protocol. The protocol can
> > go either over plain text or negotiate TLS/SSL at the beginning. This is
> > the intended use case for ssl_starttls_ack. But I found out that I can't
> > use that function since its not exported for plugins (doesn't have
> > WS_DLL_PUBLIC).
> >
> > I exported it myself in my own wireshark build and it works great, but
> > I'll be nice that others can use a standard wireshark build and just add my
> > plugin. Is there a reason for those functions (all of the
> > packet-ssl-utils.h) not to be exported? Or its just because nobody has
> > requested it so far?
> The latter.  Submit a change it it will be merged.

I just did, commit 481f53ae1014699723917bbaeebca6da5c2e732a. Hopefully
I did it right.

Thanks.


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe