Re: hf_http_response_code in packet-http.c

[Erik de Jong <erikdejong () gmail com>]

On Thu, Jul 13, 2017 at 1:12 AM, Sultan, Hassan via Wireshark-dev <
wireshark-dev () wireshark org> wrote:

> Hi,
>
>
>
> I am starting to learn the Wireshark code base, and one thing puzzles me…
>
>
>
> Why is hf_http_response_code defined as a FT_UINT16 with BASE_DEC rather
> than an FT_STRING ?
>
>
>
> It’s a text field… not an integer.

Presenting it as a number allows for filtering like:
http.response.code > 200
Which would not be possible when presented as a string.


> Anyone can enlighten me ? For the beginner that I am this looks like a
> bug, even though the display properly represent the http response code.
> Happy to send a patch if that’s case, just want to check first…
>
>
>
> Regards,
>
>
>
> Hassan Sultan
>
> ____________________________________________________________
> _______________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=
> unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe