Re: FW: Change in wireshark[master]: To get the IO graph stats for 5ms task cycle.

[Subha <subhadevi88 () gmail com>]

Hello Wireshark developers,

I have committed some changes to the IO stats graph. The code changes are
reviewed and committed some time back.

Still, I don't see the changes as part of the official build. Could someone
please explain me, if I have to send a mail to anyone to get it added to
the release.

The code changes are very minimal. Please let me know.

"*Gerrit-Change-Id: Ia2f5c44fe56ecd6c55f704c2df5e32dea947cac4*

*Gerrit-Change-Number: 33534*

*Gerrit-PatchSet: 1"*




On Thu 12 Dec, 2019, 9:18 AM Vasanthakumar Subha Devi (CAP-SST/ESS2), <
SubhaDevi.Vasanthakumar () bosch com> wrote:

> Mit freundlichen Grüßen / Best regards
>
>
>
> *Subha Devi Vasanthakumar CAP-SST/ESS2 *
> Tel. +49 7062 911-01
>
> *From:* Subha <subhadevi88 () gmail com>
> *Sent:* Wednesday, July 10, 2019 9:34 PM
> *To:* Vasanthakumar Subha Devi (CAP-SST/ESS2) <
> SubhaDevi.Vasanthakumar () bosch com>
> *Subject:* Fwd: Change in wireshark[master]: To get the IO graph stats
> for 5ms task cycle.
>
>
>
>
>
> ---------- Forwarded message ---------
> From: *Jim Young* <jim.young.ws () gmail com>
> Date: Wed 10 Jul, 2019, 4:00 PM
> Subject: Re: Change in wireshark[master]: To get the IO graph stats for
> 5ms task cycle.
> To: Subha <subhadevi88 () gmail com>
>
>
>
> Hello Subha,
>
>
>
> The process is that bugs, patches and features are worked on as people
> have the time and talent to do so.  The project is filled with volunteers.
> We work on Wireshark when we can.
>
>
>
> I'll have to review the patch later today to see where it stands.  If this
> change is accepted it will be considered to be a new feature.   New
> features are not back-ported to existing releases, very very rare
> exceptions only bug fixes are backported to the supported releasees.  New
> features will be incorporated into a new release.  Once a feature patch is
> committed into Wireshark the buildbot will produce a automated development
> build that includes the new feature.   These can be downloaded from
> Development page's "Latest Builds" link: i,e:
> https://www.wireshark.org/download/automated/
>
>
>
> It will be perhaps 12 hours at the earliest before I will have any time to
> check on this particular issue.
>
>
>
> Best regards,
>
>
>
> Jim Y.
>
>
>
> On Wed, Jul 10, 2019 at 9:01 AM Subha <subhadevi88 () gmail com> wrote:
>
> Hallo Jim,
>
>
>
> Am still not clear with the process followed at wireshark org.
>
>
>
> When would these changes be available in the official release.
>
>
>
> Could you please let me know. I tried 3.0.2 wireshark exe and development
> release 3.0.0.cr2. The changes aren't available in both .
>
>
>
> On Sun 9 Jun, 2019, 11:20 PM Subha, <subhadevi88 () gmail com> wrote:
>
> Hello Jim,
>
>
>
> Have addressed your review comment. Also, the updates changes are posted
> again in the master.
>
>
>
> Could you please check them.
>
>
>
>
>
> '
>
>
>
>
>
> Thanks,
>
> subha.
>
>
>
>
>
> On Sun, Jun 9, 2019 at 9:02 PM Jim Young (Code Review) <
> code-review-do-not-reply () wireshark org> wrote:
>
> Jim Young *posted comments* on this change.
>
> View Change <https://code.wireshark.org/review/33534>
>
> Patch set 1:
>
> (1 comment)
>
> ·         File ui/qt/io_graph_dialog.cpp:
> <https://code.wireshark.org/review/#/c/33534/1/ui/qt/io_graph_dialog.cpp>
>
> o    Patch Set #1, Line 342:
> <https://code.wireshark.org/review/#/c/33534/1/ui/qt/io_graph_dialog.cpp@342>
> ui->intervalComboBox->setCurrentIndex(3);
>
> The index should be updated to 4 from from 3 to preserve current default
> interval of 1 sec. Without the interval change the new default will be 100
> ms.
>
> To view, visit change 33534 <https://code.wireshark.org/review/33534>. To
> unsubscribe, visit settings <https://code.wireshark.org/review/settings>.
>
> Gerrit-Project: wireshark
>
> Gerrit-Branch: master
>
> Gerrit-MessageType: comment
>
> Gerrit-Change-Id: Ia2f5c44fe56ecd6c55f704c2df5e32dea947cac4
>
> Gerrit-Change-Number: 33534
>
> Gerrit-PatchSet: 1
>
> Gerrit-Owner: Subha V <subhadevi88 () gmail com>
>
> Gerrit-Reviewer: Jim Young <jim.young.ws () gmail com>
>
> Gerrit-Comment-Date: Sun, 09 Jun 2019 19:02:31 +0000
>
> Gerrit-HasComments: Yes
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe