Wireshark mailing list archives

Re: Dissector functions and variables that could be static


From: Jirka Novak <j.novak () netsystem cz>
Date: Sun, 24 Jan 2021 21:27:05 +0100

Hi,

  I checked the code I know:

epan/dissectors/packet-rtp-events.c (00000000000001a0 D> rtp_event_type_values_ext) is not referred to so could be 
static? (in>
header)
It is used in UI, outside of dissectors. Therefore it should be exported.

epan/dissectors/packet-rtp.c (00000000000006d0 T rtp_dyn_payload_remove)
is not referred to so could be static? (in header)
epan/dissectors/packet-rtp.c (0000000000000660 T
rtp_dyn_payload_replace) is not referred to so could be static? (in header)
epan/dissectors/packet-rtps.c (0000000000000e20 D class_id_enum_names)
is not referred to so could be static?

That two functions are not used at all. Can we remove them?

                                                Best regards,

                                                        Jirka Novak
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: