Re: Dissector functions and variables that could be static

[Martin Mathieson via Wireshark-dev <wireshark-dev () wireshark org>]

I have done a bit more on this - I started picking off the ones at the end
of the (alphabetical) list - 2nd one is
https://gitlab.com/wireshark/wireshark/-/merge_requests/1817. Please feel
free if anyone feels motivated to tackle some of the earlier ones.  The
script is much tidier now, and also checks for references from the ui
folder (this removed around 20 from the list), will take another pass
through it before creating an MR with it.

Sometimes I see that header files are being used as a way to untangle the
order or functions, but just doing some static forward-declarations at the
top of the C module would be better if they are not shared.  I am leery of
deleting functions that are not being called, but if they've been that way
for years they probably don't matter.

Martin



On Sun, Jan 24, 2021 at 11:06 PM Martin Mathieson <
martin.r.mathieson () googlemail com> wrote:

> On Sun, Jan 24, 2021 at 8:27 PM Jirka Novak <j.novak () netsystem cz> wrote:
>
> > Hi,
> >
> >   I checked the code I know:
> >
> > > epan/dissectors/packet-rtp-events.c (00000000000001a0 D>
> > rtp_event_type_values_ext) is not referred to so could be static? (in>
> > header)
> > It is used in UI, outside of dissectors. Therefore it should be exported.
> Yes, I can have the script also check for references from the object files
> in ui to avoid reporting cases like this.
>
> > epan/dissectors/packet-rtp.c (00000000000006d0 T rtp_dyn_payload_remove)
> > > is not referred to so could be static? (in header)
> > > epan/dissectors/packet-rtp.c (0000000000000660 T
> > > rtp_dyn_payload_replace) is not referred to so could be static? (in
> > header)
>
> I think these 2 functions can be removed.
>
> > epan/dissectors/packet-rtps.c (0000000000000e20 D class_id_enum_names)
> > > is not referred to so could be static?
> This variable is able to become static.
>
> That two functions are not used at all. Can we remove them?
> >                                                 Best regards,
> >
> >                                                         Jirka Novak
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe