Wireshark mailing list archives
Re: Petri-Dish +1 gives an error: needs code review
From: Gerald Combs <gerald () wireshark org>
Date: Fri, 15 Aug 2014 13:07:03 -0700
On 8/15/14 12:17 PM, Jeff Morriss wrote:
Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying "needs code review." Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here.
Are you pressing the "Publish Comments" or "Publish and Submit" button when this happens? We're currently using the default MaxWithBlock setting[1] for the Code-Review label, which means that submission requires at least one "+2" set and no "-2"s. It would be nice if Gerrit disabled "Publish and Submit" when the required conditions aren't met but its development team seems to prefer error messages. For what it's worth I've been trying to reduce this behavior in the Qt interface.[2] [1]https://code.wireshark.org/review/Documentation/config-labels.html#label_function [2]http://ux.stackexchange.com/questions/334/is-it-better-to-prevent-a-forbidden-action-or-display-an-error-explanation-messa ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Petri-Dish +1 gives an error: needs code review Jeff Morriss (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Graham Bloice (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Evan Huus (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review mmann78 (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Gerald Combs (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Jeff Morriss (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Christopher Maynard (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Guy Harris (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Evan Huus (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Alexis La Goutte (Aug 16)
- Re: Petri-Dish +1 gives an error: needs code review Graham Bloice (Aug 16)
- Re: Petri-Dish +1 gives an error: needs code review Alexis La Goutte (Aug 16)
- Re: Petri-Dish +1 gives an error: needs code review Jeff Morriss (Aug 15)
- Re: Petri-Dish +1 gives an error: needs code review Graham Bloice (Aug 15)