Re: Petri-Dish +1 gives an error: needs code review

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On 08/15/2014 04:07 PM, Gerald Combs wrote:
> On 8/15/14 12:17 PM, Jeff Morriss wrote:
> > Hi folks,
> >
> > One thing I've noticed about the Petri-Dish flag in Gerrit is that every
> > time I set it to +1 I get an error saying "needs code review."  Since
> > Chris just noticed and complained about that too (on change 3624) I
> > thought I'd mention it here.
>
> Are you pressing the "Publish Comments" or "Publish and Submit" button
> when this happens? We're currently using the default MaxWithBlock
> setting[1] for the Code-Review label, which means that submission
> requires at least one "+2" set and no "-2"s.

Ah, that's it.  I was (apparently--I had to try it out to confirm) 
"Publish and Submit" since, well, the other button ("Publish Comments") 
is decidedly *not* what I want to do: I want to submit my +1 (and I 
don't *have* any comments so I really didn't think I wanted to do that).

But I guess Submit means "Submit for merge" or some such, not "Submit my 
changed value."

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe