Wireshark mailing list archives
Re: Conflicts: field in commit messages
From: Pascal Quantin <pascal.quantin () gmail com>
Date: Mon, 6 Oct 2014 21:13:08 +0200
2014-10-06 21:03 GMT+02:00 Bálint Réczey <balint () balintreczey hu>:
Hi All, I usually leave the "Conflicts: ..." in the commit message after resolving conflicts to document that the merge was not automatic. Should I continue doings so you prefer removing this from the commit message? Guy raised the issue in https://code.wireshark.org/review/#/c/4438 , but I think the question deserves more attention than being just a valid code-review comment.
Hi Balint, I also remove the conflicts lines as IMHO they do not bring any added value. That said I could change my habit if other people think it is not the *right way* to do things :) Cheers, Pascal.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Conflicts: field in commit messages Bálint Réczey (Oct 06)
- Re: Conflicts: field in commit messages Pascal Quantin (Oct 06)
- Re: Conflicts: field in commit messages ronnie sahlberg (Oct 06)
- Re: Conflicts: field in commit messages Guy Harris (Oct 06)
- Re: Conflicts: field in commit messages Michal Labedzki (Oct 07)
- Re: Conflicts: field in commit messages Guy Harris (Oct 07)
- Re: Conflicts: field in commit messages Michal Labedzki (Oct 07)
- Re: Conflicts: field in commit messages Guy Harris (Oct 07)
- Re: Conflicts: field in commit messages Bálint Réczey (Oct 07)
- Re: Conflicts: field in commit messages Michal Labedzki (Oct 08)
- Re: Conflicts: field in commit messages Bálint Réczey (Oct 26)
- Re: Conflicts: field in commit messages Michal Labedzki (Oct 07)
- Re: Conflicts: field in commit messages Alexis La Goutte (Oct 07)