Re: Undissected packet bytes

[Dario Lombardo <dario.lombardo.ml () gmail com>]

Evan,
please find attached a patch that implements what I was trying to do. I'd
like to share it here with you and other devels in order to understand if
it goes in the right direction and maybe to open discussions on it. If it
seems good, I'll move it to gerrit for code review.

To test it, simply comment any proto_tree_add_item() from a dissector of
your choice, and open a packet with wireshark or with tshark -V.

Comments are welcome.
Dario.

On Thu, Feb 5, 2015 at 1:41 PM, Dario Lombardo <dario.lombardo.ml () gmail com>
wrote:

> On Thu, Feb 5, 2015 at 1:19 PM, Evan Huus <eapache () gmail com> wrote:
>
> > I believe g_log and friends go to standard out, but maybe not on all
> > platforms. An expert info under conditional compilation would probably
> > be enough though, I hadn't thought of that.
>
> Another question. I've found a promising point to put the check
> (packet.c:call_dissector_with_data()). This function is called many times
> (I can count 4 times per packet). Sometimes when tree is open, sometimes
> when it's closed. How can I navigate (and check) the tree only and only if
> it's open?
> Only in this case I can check if there are undecoded bytes.

Attachment: incomplete-dissector.diff
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe