Re: Make CMake reuse Makefile.common?

[Graham Bloice <graham.bloice () trihedral com>]

On 6 March 2015 at 15:31, Alexis La Goutte <alexis.lagoutte () gmail com>
wrote:

> On Fri, Mar 6, 2015 at 4:26 PM, Graham Bloice <graham.bloice () trihedral com
> > wrote:
>
> > On 6 March 2015 at 15:17, Peter Wu <peter () lekensteyn nl> wrote:
> >
> > > On Tue, Mar 03, 2015 at 05:50:10PM +0100, Alexis La Goutte wrote:
> > > > On Mon, Mar 2, 2015 at 1:16 PM, Peter Wu <peter () lekensteyn nl> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > Recently there have been two issues due to separate copies between
> > > CMake
> > > > > and autofoo (missing ATH dissector, missing field registrations for
> > > > > plugins).
> > > > >
> > > > > The former could occur due to missing duplication from
> > > Makefile.common
> > > > > into CMakeLists.txt. The latter happens because the
> > > > > plugins/*/CMakeLists.txt are slightly different than the Makefiles
> > > (in
> > > > > terms of variable sets).
> > > > >
> > > > > Hereby I am proposing to convert Makefile.common automatically to
> > > > > CMakeLists.inc.txt, and then include that during the build process to
> > > > > set variables. The inspiration comes from cURL which too supports
> > > > > autoconf, and (as an experimental option) cmake.
> > > > >
> > > > > See this transformation macro[0] and its use[1] for an example.
> > > > Hi Peter,
> > > >
> > > > Need to try... but i known CMake cURL is no perfect... and there is
> > > some
> > > > plan to drop support of CMake ;-)
> > >
> > > There *was* a plan to drop CMake support if nobody cared, but since then
> > > patches have been sent to improve it (also from my side).
> > the drop of CMake support is for cURL and no Wireshark ;-)
>
> > > > And also if i remember the target is only have CMake for build system
> > > (and
> > > > remove autofoo...)
> > >
> > > That would be great, but I would not rush this yet, there are still some
> > > cmake issues like
> > > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10074. (other issues
> > > I have found, but for which no bug is filled: the path to xdg-open is
> > > fully expanded by cmake).
> > >
> > > How are the windows binaries currently build? Using nmake I believe?
> > As mentioned elsewhere Windows CMake is getting good now, still some
> > issues to be sorted, but I'm hopeful of getting there by SF15.
> Plan a session on SF15 about fixing CMake issue stuff ? ;-)
>
> >

1 slide : Call Jörg
<https://code.wireshark.org/review/#/q/owner:%22J%25C3%25B6rg+Mayer%22+status:merged,n,z>
!

-- 
Graham Bloice

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe