Re: proto.h extension

[Guy Harris <guy () alum mit edu>]

On May 7, 2015, at 8:13 AM, "John Dill" <John.Dill () greenfieldeng com> wrote:

> I have a couple of extensions that I created for the Wireshark baseline that we're using (1.10.x).  The diffs to 
> proto.h and proto.c show the code changes to add a couple of features that I've found useful, unit strings and hiding 
> the bits for bitmask header fields.
>
> http://codepad.org/KTGdEL1t 

You need more than

        /* Following constants have to be ORed with a base_display_e when dissector
         * want to control aspects of the display string for a header_field_info */

as a comment there - you need comments explaining what each of those flags actually *does*.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe