Wireshark mailing list archives
Re: checklicenses.py
From: João Valverde <joao.valverde () tecnico ulisboa pt>
Date: Sat, 6 Aug 2016 21:21:09 +0100
On 08/05/2016 08:17 PM, João Valverde wrote:
On 08/05/2016 11:53 AM, João Valverde wrote:On 08/05/2016 11:50 AM, Guy Harris wrote:On Aug 5, 2016, at 3:36 AM, João Valverde <joao.valverde () tecnico ulisboa pt> wrote:On 08/05/2016 11:21 AM, Guy Harris wrote:Should we just grab some version that works and include it in the tools directory, so that we don't get mysterious failures when updating the version of Ubuntu on the buildbot and don't fail - or require somebody to dig up or install via CPAN - on systems that don't distribute it?No... too many CPAN dependencies.I.e., it's not a standalone script, and you'd have to get a ton of other scripts from CPAN and distribute them as well?Yes (naturally this is the dependency problem CPAN itself tries to solve).The Debian licensecheck.pl version prior to the Smedegaard take over was standalone. I think we should import that to tools.
Done in https://code.wireshark.org/review/#/c/16913/.The master buildbot check licenses step is passing with a FIXME_FILES exception but let's not leave this hack in there forever...
I just added that because the new failures were caused by the differentlicensecheck.pl version. Hopefully FIXME_FILES will be removed soon with a better solution.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: checklicenses.py, (continued)
- Re: checklicenses.py João Valverde (Aug 08)
- Re: checklicenses.py Guy Harris (Aug 08)
- Re: checklicenses.py João Valverde (Aug 08)
- Re: checklicenses.py Guy Harris (Aug 08)
- Re: checklicenses.py João Valverde (Aug 08)
- Re: checklicenses.py Guy Harris (Aug 08)
- Re: checklicenses.py João Valverde (Aug 08)
- Re: checklicenses.py Guy Harris (Aug 08)
- Re: checklicenses.py João Valverde (Aug 08)
- Re: checklicenses.py Guy Harris (Aug 08)
- Re: checklicenses.py João Valverde (Aug 06)
- Re: checklicenses.py Guy Harris (Aug 06)
- Re: checklicenses.py João Valverde (Aug 06)
- Re: checklicenses.py Michael Mann (Aug 06)
- Re: checklicenses.py João Valverde (Aug 06)
- Re: checklicenses.py João Valverde (Aug 06)
- Re: checklicenses.py João Valverde (Aug 05)