Wireshark mailing list archives

Re: Multiple TRANSUM fixes


From: Richard Sharpe <realrichardsharpe () gmail com>
Date: Mon, 13 Nov 2017 10:57:34 -0800

On Mon, Nov 13, 2017 at 10:32 AM, Paul Offord <Paul.Offord () advance7 com> wrote:
Hi Richard,

Yes that does sound best.  You know when you enter the line:

Bug:  12345

I suspect you can add multiple Bug: 12345 lines, but do not know.

into the commit comment, can I list the bugs?  And if I do, will gerrit update Bugzilla?  I'm guessing not for all, 
so what the best way to handle this?

Thanks and regards...Paul

-----Original Message-----
From: Wireshark-dev [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Richard Sharpe
Sent: 13 November 2017 18:13
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Subject: Re: [Wireshark-dev] Multiple TRANSUM fixes

On Mon, Nov 13, 2017 at 10:09 AM, Paul Offord <Paul.Offord () advance7 com> wrote:
Hi,



I want to submit a patched packet-transum.c file.  It fixes three
bugs, none of which are currently on Bugzilla.  Should I submit three
bugs and then refer to all three bugs in the patch commit comments?
Or can I specify all three bugs in one Bugzilla report?  What’s the correct form?

I would say submit three separate bugs. This eases management, because if later one of your fixes is found to be 
incomplete, and you only filed one bug, it becomes confusing when we reopen that one bug.

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

______________________________________________________________________

This message contains confidential information and is intended only for the individual named. If you are not the 
named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by 
e-mail if you have received this e-mail by mistake and delete this e-mail from your system.

Any views or opinions expressed are solely those of the author and do not necessarily represent those of Advance 
Seven Ltd. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, 
corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept 
liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission.

Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour House, Coopers End Lane, Stansted, 
Essex CM24 1SJ

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe



-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: