Re: Multiple TRANSUM fixes

[Michael Mann via Wireshark-dev <wireshark-dev () wireshark org>]

You need separate line for each bug, ie.
 
Bug: 12345
Bug: 12346
Bug: 12347
 
When you do that on the initial push, gerrit will mark the bugs.  If you do it after the initial commit, the bugs will 
only be notified when patch is submitted to master.
The ability for Gerrit to actually move bug to closed state has been broken for awhile, so typically the core developer 
who submits the patch ends up "manually" closing the bugs referenced in the commit message.
 
 
-----Original Message-----
From: Paul Offord <Paul.Offord () advance7 com>
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Sent: Mon, Nov 13, 2017 1:33 pm
Subject: Re: [Wireshark-dev] Multiple TRANSUM fixes

Hi Richard,Yes that does sound best.  You know when you enter the line:Bug:  12345into the commit comment, can I list 
the bugs?  And if I do, will gerrit update Bugzilla?  I'm guessing not for all, so what the best way to handle 
this?Thanks and regards...Paul-----Original Message-----From: Wireshark-dev [mailto:wireshark-dev-bounces () wireshark 
org] On Behalf Of Richard SharpeSent: 13 November 2017 18:13To: Developer support list for Wireshark <wireshark-dev () 
wireshark org>Subject: Re: [Wireshark-dev] Multiple TRANSUM fixesOn Mon, Nov 13, 2017 at 10:09 AM, Paul Offord 
<Paul.Offord () advance7 com> wrote:> Hi,>>>> I want to submit a patched packet-transum.c file.  It fixes three > bugs, 
none of which are currently on Bugzilla.  Should I submit three > bugs and then refer to all three bugs in the patch 
commit comments?  > Or can I specify all three bugs in one Bugzilla report?  What’s the correct form?I would say submit 
three separate bugs. This eases management, because if later one of your fixes is found to be incomplete, and you only 
filed one bug, it becomes confusing when we reopen that one bug.--Regards,Richard 
Sharpe(何以解憂？唯有杜康。--曹操)___________________________________________________________________________Sent via:    
Wireshark-dev mailing list <wireshark-dev () wireshark org>Archives:    
https://www.wireshark.org/lists/wireshark-devUnsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev       
      mailto:wireshark-dev-request () wireshark 
org?subject=unsubscribe______________________________________________________________________This message contains 
confidential information and is intended only for the individual named. If you are not the named addressee you should 
not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received 
this e-mail by mistake and delete this e-mail from your system.Any views or opinions expressed are solely those of the 
author and do not necessarily represent those of Advance Seven Ltd. E-mail transmission cannot be guaranteed to be 
secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or 
contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this 
message, which arise as a result of e-mail transmission.Advance Seven Ltd. Registered in England & Wales numbered 
2373877 at Endeavour House, Coopers End Lane, Stansted, Essex CM24 
1SJ______________________________________________________________________This email has been scanned by the Symantec 
Email Security.cloud service.For more information please visit 
http://www.symanteccloud.com_________________________________________________________________________________________________________________________________________________Sent
 via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>Archives:    
https://www.wireshark.org/lists/wireshark-devUnsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev       
      mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe